Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V14: Add missing healthcheck translations #16612

Merged
merged 2 commits into from
Jun 18, 2024
Merged

V14: Add missing healthcheck translations #16612

merged 2 commits into from
Jun 18, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Jun 17, 2024

Fixes #16479

Notes

How to test

  • Follow steps in original issue, there should no longer be translation keys "[HeaderNotFound]" but proper text instead 👍

@Zeegaan Zeegaan changed the title V14/bugfix/add missing healthcheck translations V14: Add missing healthcheck translations Jun 17, 2024
nikolajlauridsen
nikolajlauridsen approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nikolajlauridsen nikolajlauridsen merged commit 8edb188 into v14/dev Jun 18, 2024
15 of 16 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v14/bugfix/add-missing-healthcheck-translations branch June 18, 2024 08:41
@nikolajlauridsen nikolajlauridsen mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolajlauridsen nikolajlauridsen nikolajlauridsen approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeegaan @nikolajlauridsen @iOvergaard